Maintenance: Rework playback to use Player.Open #1215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
rework_playeropen
branch
3 times, most recently
from
4bfc8ba to
d5786a8
Compare
wutschel
force-pushed
the
rework_playeropen
branch
from
d5786a8 to
6667bc9
Compare
Avoid to use Playlist.Clear, Playlist.Add and starting to play a playlist index. Instead, directly call Player.Open with the item, which then allows to resume the position via API. As Player.Open anyway will clear and update the playlist, this is a much simpler and more robust way to start or resume the playback.
Check support of Playlist.Insert/.Add for recordings is not required when starting a slideshow, as this does not use any Playlist API anymore.
This is now done purely by calling Player.Open, and not by updating a playlist and playing from the desired playlist index.
Video addons can now be processed by the default logic, as also Player.Open is used.
"Play using..." can now be processed by the default logic, as also Player.Open is used.
Live TV / Radio can now be processed by the default logic inside buildPlaylistItems.
This enables the activity indicator.
Only either indexPath or the ActivityIndicator is needed.
wutschel
force-pushed
the
rework_playeropen
branch
from
6667bc9 to
0713dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR finishes the work started in #1200 and reworks / re-implements the way of how playback of items is started. Before, items were first added to a playlist (
Playlist.Clear,Playlist.Add), then the playback was started for this playlist (Player.Openfor playlist id and playlist index).There were already exceptions to this approach when resuming, when starting a slideshow, when starting playback for PVR channels or streams or when starting playback to a UPnP renderer. After this rework the playback is always started by a common
Player.Opencommand for a givenitem, usingoptionswhich cover the shuffle mode as well as UPnP.Along with this change the behaviour of play/queue in the album view is made consistent. Selecting play/queue on a track will always only process the selected track, selecting play/queue on the album will process the whole album.
Summary for release notes
Maintenance: Rework playback to use Player.Open
Improvement: Consistent behaviour of play/queue in album view